ScrollablePane SCSS to MergeStyles Part 2: Style Conversion#4010
Merged
oengusmacinog-zz merged 6 commits intomicrosoft:masterfrom Feb 20, 2018
Merged
Conversation
mikewheaton
reviewed
Feb 20, 2018
| BaseComponent, | ||
| css | ||
| classNamesFunction, | ||
| css, |
Contributor
There was a problem hiding this comment.
Is css still being used somewhere?
Collaborator
Author
There was a problem hiding this comment.
Good catch :)
| overflowY: 'auto', | ||
| maxHeight: 'inherit', | ||
| height: 'inherit', | ||
| // @todo this doesn't work with JS |
Contributor
There was a problem hiding this comment.
Is this a regression if we merge as-is?
Collaborator
Author
There was a problem hiding this comment.
Actually I should ask @dzearing about this. Unfortunately it is not included in the JS Api, so I it is not as simple as adding an IRawStyle. I did a little research, but the general comment was that if you want to get this specific with your styles, don't style with JS as it's just not there yet. This will not cause a visual regression though, only cause scroll behavior to differ on specific webkit browsers like Opera and Chrome.
Also, @betrue-final-final do you know how important this rule is design wise, or if it was just added out of convenience?
jordandrako
approved these changes
Feb 20, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* master: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* origin: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Convert all SCSS to MergeStyles in ScrollablePane component.