Dialog: modal props now mixed correctly#4045
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Feb 21, 2018
dzearing:fix-dialog-props
Merged
Dialog: modal props now mixed correctly#4045dzearing merged 2 commits intomicrosoft:masterfrom dzearing:fix-dialog-props
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:fix-dialog-props
Conversation
Member
Author
|
@betrue-final-final @lynamemi Here you go. :) |
Member
|
I can just abandon my PR now? |
Member
Author
|
@betrue-final-final Yup, I abandoned it for you already ;) |
Collaborator
|
Yay, thank you! :) |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* master: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* origin: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in Dialog where "defaults" would be easily overwritten for
modalPropsanddialogContentProps.This change now mixes the user provided values in with defaults. This means we respect the default white overlay for Modal.