Conversation
manishgarg1
requested review from
Jahnp,
ThomasMichon,
aditima,
atneik,
cschleiden,
johannao76,
joschect,
lorejoh12,
micahgodbolt,
mikewheaton,
phkuo and
yiminwu
as code owners
cschleiden
suggested changes
Feb 19, 2018
| /** | ||
| * Gets the base button styles. Note: because it is a base class to be used with the `mergeRules` | ||
| * helper, it should have values for all class names in the interface. This let `mergeRules` optimize | ||
| * helper, it should have values for all class names in the interface. This const `mergeRules` optimize |
Contributor
There was a problem hiding this comment.
How did you make the changes? search/replace or using tslint autofix? We shouldn't change comments #Resolved
Collaborator
Author
There was a problem hiding this comment.
Thanx for the review @cschleiden. This and a few others are already fixed. #Resolved
dzearing
reviewed
Feb 19, 2018
| "variable-name": false, | ||
| "no-internal-module": false, | ||
| "prefer-const": false, | ||
| "prefer-const": true, |
Member
There was a problem hiding this comment.
This should just be deleted, and you should update the default oufr-tslint/tslint.json to be true. This might mean you need to set it to false elsewhere.
#Resolved
Collaborator
Author
There was a problem hiding this comment.
Got it. Let me fix that. #Resolved
Collaborator
Author
There was a problem hiding this comment.
manishgarg1
requested a review
from KatherineThayerMicrosoft
as a code owner
cschleiden
approved these changes
Feb 19, 2018
Member
|
I have disabled the pr deploy workflow in vsts for now. |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* master: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 21, 2018
* origin: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
(give an overview)
Focus areas to test
(optional)