Make sure componentRef types match base component type #4330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
BaseComponent defines the
componentRefas receivingnullas a possible value.However a lot of the components defined the prop without taking the
nullvalue into account. But do not guarantee that this is actually the case in the component. This caused a hole in the type system as the function can be called withnullbut we don't protect against it.This PR fixes up all the componentRef type definitions by adding the possible
nullvalue.componentRef?: (component: ICommandBar | null) => void;
Focus areas to test
Effects types only, so should not have any effect on JS.