Add missing icons to Signal and minor visual updates#4343
Merged
lynamemi merged 3 commits intomicrosoft:masterfrom Mar 23, 2018
Merged
Add missing icons to Signal and minor visual updates#4343lynamemi merged 3 commits intomicrosoft:masterfrom
lynamemi merged 3 commits intomicrosoft:masterfrom
Conversation
ahackettms
reviewed
Mar 22, 2018
| className={ css(SignalStyles.signal, SignalsStyles.youCheckedOutl) } | ||
| iconName='' | ||
| iconName='checkedoutbyyou12' | ||
| /> // TODO get correct icon |
Contributor
There was a problem hiding this comment.
also could you double check the SomeoneCheckedOutSignal, the icon is 'navigateForwad', is that right? There is an icon of CheckedOutByOther12
Member
Author
There was a problem hiding this comment.
I just went over the list with the designer and re-updated. Should be all good now.
ahackettms
approved these changes
Mar 23, 2018
ahackettms
approved these changes
Mar 23, 2018
lynamemi
approved these changes
Mar 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change brings in more icons to
Signalsand makes minor visual corrections.