Skip to content

Enable jsx key#4017

Merged
dzearing merged 4 commits intomicrosoft:masterfrom
Markionium:enable-jsx-key
Feb 20, 2018
Merged

Enable jsx key#4017
dzearing merged 4 commits intomicrosoft:masterfrom
Markionium:enable-jsx-key

Conversation

@Markionium
Copy link
Copy Markdown
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Enables the temporary disabled jsx-key rule.

Focus areas to test

(optional)

Copy link
Copy Markdown
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dzearing dzearing merged commit 6d58ab7 into microsoft:master Feb 20, 2018
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Feb 21, 2018
* master:
  Applying package updates.
  Features/disabled link pointer events (microsoft#4020)
  Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037)
  Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036)
  Dialog: modal props now mixed correctly (microsoft#4045)
  Rating type (microsoft#4046)
  Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042)
  ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010)
  Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006)
  SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035)
  Enable jsx key (microsoft#4017)
  make onShouldVirtualize work for grouped list (microsoft#4021)
  ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022)
  Misc changes from 6.0 branch (microsoft#4031)
  Enable prefer-const tslint flag (microsoft#4018)
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Feb 21, 2018
* origin:
  Applying package updates.
  Features/disabled link pointer events (microsoft#4020)
  Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037)
  Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036)
  Dialog: modal props now mixed correctly (microsoft#4045)
  Rating type (microsoft#4046)
  Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042)
  ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010)
  Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006)
  SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035)
  Enable jsx key (microsoft#4017)
  make onShouldVirtualize work for grouped list (microsoft#4021)
  ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022)
  Misc changes from 6.0 branch (microsoft#4031)
  Enable prefer-const tslint flag (microsoft#4018)
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants