Nav SCSS to MergeStyles Part 2: Style Conversion#4056
Merged
oengusmacinog-zz merged 6 commits intomicrosoft:masterfrom Feb 21, 2018
Merged
Nav SCSS to MergeStyles Part 2: Style Conversion#4056oengusmacinog-zz merged 6 commits intomicrosoft:masterfrom
oengusmacinog-zz merged 6 commits intomicrosoft:masterfrom
Conversation
mikewheaton
approved these changes
Feb 21, 2018
| import * as stylesImport from './Nav.scss'; | ||
| const styles: any = stylesImport; | ||
| import { AnimationClassNames, mergeStyles } from '../../Styling'; | ||
| // import * as stylesImport from './Nav.scss'; |
Contributor
There was a problem hiding this comment.
Make sure these commented lines are removed before merging.
Collaborator
Author
There was a problem hiding this comment.
Done. Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Convert all SCSS to MergeStyles in Nav component.