Integrating Webpack 4#4320
Merged
dzearing merged 8 commits intomicrosoft:masterfrom Mar 24, 2018
dzearing:webpack-4
Merged
Conversation
dzearing
requested review from
Jahnp and
KatherineThayerMicrosoft
as code owners
christiango
reviewed
Mar 20, 2018
| "@microsoft/loader-load-themed-styles": "^1.6.0", | ||
| "@uifabric/merge-styles": ">=5.13.0 <6.0.0", | ||
| "autoprefixer": "^7.1.5", | ||
| "awesome-typescript-loader": "^3.2.3", |
Member
Author
There was a problem hiding this comment.
i'm going to revert to trim down changes.
christiango
reviewed
Mar 20, 2018
| optimization: { | ||
| concatenateModules: true, | ||
| minimize: true | ||
| }, |
Member
There was a problem hiding this comment.
these are the defaults for mode:production, you can omit this
Member
There was a problem hiding this comment.
If you aren't seeing dev mode work, you probably need to update merge to make sure that you are deep copying all properties in the config when merging. We had a similar issue where our "merge" ended up with a reference to the same optimization object for development and production mode, which caused the defaults webpack applies in the devmode run to get applied in production mode.
Member
Author
There was a problem hiding this comment.
Good catch, I know about mode but i was testing these individually,.
christiango
approved these changes
Mar 20, 2018
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates to webpack 4 and ts-loader.
It also adjusts
typingslocations in package.json, while also addingmoduleentry points andsideEffects: falsefor tree shaking to work.It does not change the
/lib/references anywhere. We'll need to figure that out in a separate step.