[TextField] input "size" attribute#4060
Merged
lambertwang-zz merged 3 commits intomicrosoft:masterfrom Feb 21, 2018
Merged
Conversation
lambertwang-zz
changed the title
joschect
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Size is set to 1 for the input element in order to force the browser to respect the width set on parent elements. When size is set, it tells the browser it must show at least that number of characters in the textfield. Size defaults to 20 which forces the field to have a minimum width that may be larger than the intended size of the textfield.
See: https://html.spec.whatwg.org/multipage/input.html#the-size-attribute