Skip to content

Add DocumentCardLogo and DocumentCardStatus for supporting conversation activity card#4299

Merged
inateeg merged 12 commits intomicrosoft:masterfrom
inateeg:inateeg/0302card
Mar 21, 2018
Merged

Add DocumentCardLogo and DocumentCardStatus for supporting conversation activity card#4299
inateeg merged 12 commits intomicrosoft:masterfrom
inateeg:inateeg/0302card

Conversation

@inateeg
Copy link
Copy Markdown
Collaborator

@inateeg inateeg commented Mar 16, 2018

SPO Activity webpart now show group conversation activity card. it needs those two new entity to be able to show conversation activities.

@inateeg
Copy link
Copy Markdown
Collaborator Author

inateeg commented Mar 21, 2018

Changes are used for ConversationTile from group conversation activity.

"localLinks": {
"fabric-website": [
"@uifabric/utilities",
"office-ui-fabric-react"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm confused why these files are in the PR...

Copy link
Copy Markdown
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary files

{
"packageName": "office-ui-fabric-react",
"comment": "Add DocumentCardLogo and DoucmentCardStatus for Conversation card",
"type": "patch"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

@inateeg inateeg merged commit d4159b2 into microsoft:master Mar 21, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants