Enable jsx no string ref#4016
Merged
dzearing merged 14 commits intomicrosoft:masterfrom Feb 22, 2018
Merged
Conversation
* master: (71 commits) Applying package updates. Delete initials_2018-02-07-13-49.json Delete initials_2018-02-07-13-49.json Delete jolore-addingWorkWeekDateRange_2018-01-24-01-39.json Delete initials_2018-02-07-13-49.json Delete jolore-addingWorkWeekDateRange_2018-01-24-01-39.json Delete initials_2018-02-07-13-49.json Update .npmrc Cleaning Up Console Log in CommandBar Test (microsoft#4011) Convert Overlay to mergeStyles (microsoft#3978) ScrollablePane SCSS to MergeStyles Part 1: File Structure (microsoft#4008) [ContextualMenu] Fixes useTargetWidth property (microsoft#3943) DetailsList: Consider groups when setting aria-rowcount List: Add a _notifyPageChanges function (microsoft#3990) Applying package updates. Migrating Coachmark to main Package, Added a beak component and updated experiment PositioningContainer. (microsoft#3919) Update package.json Added enum for triggering menu with arrow keys and bool to allow it or not (microsoft#3950) BaseExtendedPicker: Hook up onPaste (microsoft#3885) FocusUtil: fix getPreviousElement to include previous sibling elements correctly (microsoft#3928) ...
Markionium
requested review from
aditima,
cschleiden,
johannao76,
joschect,
lorejoh12 and
micahgodbolt
as code owners
Member
|
@Markionium there are some const conflicts; can you pull master into your branch? Also, take a look at the screener failures. I think they are valid breaks. Can you take a look at the overflow menu in commandbar? You can go to apps/vr-tests and run npm start to see the individual screenshot storybook tests that failed. |
dzearing
requested changes
Feb 21, 2018
Member
dzearing
left a comment
dzearing
left a comment
There was a problem hiding this comment.
Resolve conflicts, take a look at the screener breaks.
* origin: Applying package updates. Features/disabled link pointer events (microsoft#4020) Image SCSS to MergeStyles Part 1: File Structure (microsoft#4037) Nav SCSS to MergeStyles Part 1: File Structure (microsoft#4036) Dialog: modal props now mixed correctly (microsoft#4045) Rating type (microsoft#4046) Dialog: Converting to mergeStyles part 1 - file structure. (microsoft#4042) ScrollablePane SCSS to MergeStyles Part 2: Style Conversion (microsoft#4010) Spin Button and Checkbox: Added Support for aria-setsize and aria-posinset (microsoft#4006) SwatchColorPicker: Improve keyboarding/mouse experience (microsoft#4035) Enable jsx key (microsoft#4017) make onShouldVirtualize work for grouped list (microsoft#4021) ResizeGroup SCSS to MergeStyles Part 1: File Structure (microsoft#4022) Misc changes from 6.0 branch (microsoft#4031) Enable prefer-const tslint flag (microsoft#4018)
dzearing
approved these changes
Feb 21, 2018
dzearing
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Re-enables
jsx-no-string-ref. Some components that seemed to have unused public refs are made private.This is a breaking change as refs are now available on the component directly, according to our BESTPRACTICES, instead of on the .refs object.
Focus areas to test
Any components where the refs changed or public refs are used.