Contextual Menu: Added aria-setsize and aria-posinset for rendering split buttons#4044
Merged
dzearing merged 7 commits intomicrosoft:masterfrom Feb 21, 2018
Merged
Contextual Menu: Added aria-setsize and aria-posinset for rendering split buttons#4044dzearing merged 7 commits intomicrosoft:masterfrom
dzearing merged 7 commits intomicrosoft:masterfrom
Conversation
joschect
approved these changes
Feb 21, 2018
dzearing
reviewed
Feb 21, 2018
| aria-haspopup={ true } | ||
| aria-describedby={ item.ariaDescription } | ||
| aria-checked={ item.isChecked || item.checked } | ||
| aria-posinset={ focusableElementIndex + 1 } |
Member
There was a problem hiding this comment.
Can you please add a change file so that this change gets published?
Contributor
Author
There was a problem hiding this comment.
Oops, I knew I forgot something. Added.
dzearing
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently if we try to render a split button in the contextual menu we don't give it an aria-setsize and aria-posinset like we do for regular buttons
Solution:
Added the aria properties in for when we're rendering a split button in contextual menus
Validation
In the contextual menu page, I validated that we now have the appropriate aria-setsize and aria-posinset values set.