DetailsList: headers now resize again.#4325
Merged
dzearing merged 7 commits intomicrosoft:masterfrom Mar 21, 2018
dzearing:detailsheader-fix
Merged
DetailsList: headers now resize again.#4325dzearing merged 7 commits intomicrosoft:masterfrom dzearing:detailsheader-fix
dzearing merged 7 commits intomicrosoft:masterfrom
dzearing:detailsheader-fix
Conversation
aditima
approved these changes
Mar 21, 2018
| const rootElement = this._root.value; | ||
|
|
||
| const focusZone = this._root.value; | ||
| const rootElement = ReactDOM.findDOMNode(focusZone as any); |
Contributor
There was a problem hiding this comment.
Did you find a way to remove the any?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4309.
The
createRefchanges screwed up the FocusZone ref logic in DetailsHeader, which broke column resizing. There also wasn't test coverage for this scenario. I've fixed the issue, and added a test to verify that we can resize.We also now respect maxWidth if provided as well. (if it's set to 0 or undefined we will let the user resize as much as they want.