Remove extra tooltip in dropdown#4272
Merged
cschleiden merged 2 commits intomicrosoft:masterfrom Mar 22, 2018
Merged
Conversation
|
|
Contributor
Author
|
@cschleiden Can you take a look at this and let me know if it's ok to merge? Thanks! |
cschleiden
approved these changes
Mar 22, 2018
preetriti
reviewed
May 24, 2018
preetriti
left a comment
preetriti
left a comment
There was a problem hiding this comment.
Can you please not do this? This is very useful when the items in the dropdown have very long names and the displayed text is cutoff and full name is shown in title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Remove the tooltip from the basic dropdown button. The tooltip is the same as the text displayed in the button itself, so it is redundant.
Focus areas to test
(optional)