Stanleyy/fillin#4351
Merged
stanleyymsft merged 27 commits intomicrosoft:masterfrom Mar 23, 2018
Merged
Conversation
added 25 commits
February 6, 2018 14:28
jspurlin
reviewed
Mar 23, 2018
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Add multiSelect capability for ComboBox", |
Contributor
There was a problem hiding this comment.
I don't think this changefile is needed since the one below seems to be the correct file. Can you remove this one?
Collaborator
Author
There was a problem hiding this comment.
You are right. Will delete.
jspurlin
approved these changes
Mar 23, 2018
Contributor
jspurlin
left a comment
jspurlin
left a comment
There was a problem hiding this comment.
Remove the extra/outdated changefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
ComboBox: Add some code comments. Minor bug fixes to the example page.
Focus areas to test
Just minor changes in code comment and example page.