Closed
Conversation
Fix notice in user logout
* Update joomla/filter to 1.4.2 * Update joomla/filter to 1.4.3
* Added missind deprecation * and will be removed in 4.0
* Remove itemprop="url" from readmore * remove space
The label inline editing is wrong. Inline editing is not having buttons to open an edit form.
Fixes a simple copy paste error with the id of the modal
* Update remove.js * Thanks @richard67 Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* Update script.php * Update script.php * revert
Use padding instead of a space between the icon and the text to avoid the link styling on the space ### Before ### After
* Remove checkin, checkout from ProfileModel * Remove un-used use statements
…2550) * Fixed menu params for front page item on installation. * Fixed postgres installation file as well. * Added show_associations menu parameter.
* Cleanup postinstall messages in update * Update administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-12-31.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Add msg ADDNOSNIFF * Fix Langige file com_cpanel * updates as suggested. * Rename update SQL scripts to 4.0.0-2021-02-28.sql * remove language strings * remove msg eaccelerator, chnages sql statement, add files to script for deleting * Move deleted files to the right place in script.php * Update administrator/components/com_admin/sql/updates/postgresql/4.0.0-2021-02-28.sql Nice (inofficial) code style for the SQL file. Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* Improve Article Model * Respect category permission for frontend article submission * Fix warning
* [4.0] Field layout attribute * revert display attribute * inc joomla.content.options_default * Revert "revert display attribute" This reverts commit b1e13e1. * rename to parentclass * Update layouts/joomla/form/renderfield.php Co-authored-by: Quy <quy@fluxbb.org> * Update CalendarField.php * Update CalendarField.php * add since to all * component configs * Update article.xml Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Quy <quy@fluxbb.org>
Looks like this came from a search and replace when converting to bs5 code review
There is no module chrome for atum called "no" and this must have been intended to be "none"
Spotted these small codestyle issues while testing something else code review only
* Update joomla-image-select.css * Update global.scss and joomla-image-select.css * Revert "Update global.scss and joomla-image-select.css" This reverts commit c73ef1d. * Style are made as required * adding good code practice Co-authored-by: Quy <quy@fluxbb.org> * adding good code practice * This makes the necessary changes required joomla#32797 * Revert "This makes the necessary changes required joomla#32797" This reverts commit 8a5e982. * This make neccessary changes required * Revert "This make neccessary changes required" This reverts commit 68c7c41. * Adding border Co-authored-by: Quy <quy@fluxbb.org>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border. All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes. This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses. Testers dont forget to run npm to rebuild the css The easies way to to check this would be in the article list after enabling the voting plugin
astridx
requested review from
HLeithner,
bembelimen,
rdeutz and
wilsonge
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # #31524 (comment).
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required