[4] Ensure updates installed by previous package updates dont error#32936
Merged
rdeutz merged 1 commit intojoomla:4.0-devfrom Mar 31, 2021
PhilETaylor:fixupdater
Merged
[4] Ensure updates installed by previous package updates dont error#32936rdeutz merged 1 commit intojoomla:4.0-devfrom PhilETaylor:fixupdater
rdeutz merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:fixupdater
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com> revert part of the purge Signed-off-by: Phil E. Taylor <phil@phil-taylor.com> revert deleting on successful install of an update Signed-off-by: Phil E. Taylor <phil@phil-taylor.com> add trailing period for codestyle Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor
|
I have tested this item ✅ successfully on f1303cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936. |
Contributor
|
I have tested this item ✅ successfully on f1303cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936. |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32917
Summary of Changes
Break out of the foreach loop if we cannot load the update information from the database instead of generating an error message.
Testing Instructions
Joomla 4.0-dev (Enable Debug mode in Joomla Global Config)
Install an old version (only just old!) of Akeeba Backup Core (FREE) from https://www.akeeba.com/download/akeeba-backup/8-0-2/pkg_akeeba-8-0-2-core-zip.zip
Once installed go to:
System -> Update -> Extensions
Click Clear Cache
Click Find Updates
See three available updates
Select ALL THREE UPDATES and click UPDATE..... wait.....
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Depending on when you test there might be more updates available and found, but you should now at least be able to select a package (Akeeba Backup) and all the other updates, and the package (Akeeba Backup) will update the others (as that's what a package is for - doh!) and the others will not error like they did before.
Documentation Changes Required
None.
Additional comments
// @nikosdion @joomdonation @alikon