[4.0] Fix installation folder not being deleted#32599
Merged
infograf768 merged 2 commits intojoomla:4.0-devfrom Mar 6, 2021
Merged
[4.0] Fix installation folder not being deleted#32599infograf768 merged 2 commits intojoomla:4.0-devfrom
infograf768 merged 2 commits intojoomla:4.0-devfrom
Conversation
joomdonation
changed the title
richard67
reviewed
Mar 6, 2021
Contributor
|
I have tested this item ✅ successfully on e1db87f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32599. |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Member
|
Last code change was just code style, so the previous test result is still valid. I've restored it in the issue tracker so it's correctly counted. |
Member
|
Will test asap. |
Contributor
Author
Yes, please ! |
Contributor
|
I have tested this item ✅ successfully on 868a698 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32599. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32599. |
Member
|
Tks! |
Member
|
Folks, please test #32601 |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Mar 17, 2021
* Update remove.js * Thanks @richard67 Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32516.
Summary of Changes
This small PR fixes installation folder not being deleted. See #32516 for detailed description of the issue
Testing Instructions