Skip to content

Comments

[4.0] Fixed menu params for front page item on installation#32550

Merged
rdeutz merged 3 commits intojoomla:4.0-devfrom
Harmageddon:fix_installation_menu_params
Mar 10, 2021
Merged

[4.0] Fixed menu params for front page item on installation#32550
rdeutz merged 3 commits intojoomla:4.0-devfrom
Harmageddon:fix_installation_menu_params

Conversation

@Harmageddon
Copy link
Contributor

Pull Request for Issue #32493. Note: This is not an alternative to #32547 - both are necessary. #32547 for fixing the notice and another error, and this PR here for fixing the underlying cause.

Summary of Changes

The "home" menu item that is created on installation contains parameters from 3.x, and lacks parameters from 4.x. This PR fixes the installation SQL.

Testing Instructions

IMHO, this could be merged on code review. Testing instructions are a bit more complicated here.

  1. Install a clean 4.0-beta7 or nightly.
  2. Important: Don't edit the "home" menu item!
  3. Create 4 articles and set them as featured and published.
  4. Look at the home page. The articles should be displayed in a one-column layout.
  5. Update using a 4.0-beta7 or nightly update package.
  6. Look again at the home page.

Using the prebuilt packages for this PR, do a clean new installation and repeat steps 2-6.

Actual result BEFORE applying this Pull Request

Before the update, the "home" item displays articles in a one-column layout. After running an update, it displays them in three columns.

Expected result AFTER applying this Pull Request

Updating should not change the layout.

Documentation Changes Required

none

@richard67
Copy link
Member

@Harmageddon And installation/sql/postgresql/base.sql doesn't need a fix? That seems strange to me.

@Harmageddon
Copy link
Contributor Author

@richard67 Of course, you're absolutely right. Thank you!

@ChristineWk
Copy link

I have tested this item ✅ successfully on 726972d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@particthistle
Copy link
Member

I have tested this item ✅ successfully on 726972d

Tested successfully.

Have also followed up @infograf768 comment on #32525 to help @AndySDH update the relevant parameters in the sample data script to also avoid J3 parameters being included and J4 parameters being missed in what that PR does.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 2, 2021
@infograf768
Copy link
Member

show_associations should be added as it is a blog/featured parameter (Options).

Screen Shot 2021-03-02 at 11 10 03

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Mar 2, 2021
@richard67
Copy link
Member

Back to pending.

@Harmageddon Could you check #32550 (comment) ? Thanks in advance.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 2, 2021
@Harmageddon
Copy link
Contributor Author

Sorry for the delayed response, I didn't have much time during the week.

Thank you @infograf768 for the suggestion! I added it to both files.

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 7, 2021
@ChristineWk
Copy link

ChristineWk commented Mar 7, 2021

(fyi: sandk2)
I have tested this item ✅ successfully on ffcfc80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on ffcfc80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 8, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 8, 2021
@rdeutz rdeutz merged commit 0043347 into joomla:4.0-dev Mar 10, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 10, 2021
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Mar 17, 2021
…2550)

* Fixed menu params for front page item on installation.

* Fixed postgres installation file as well.

* Added show_associations menu parameter.
@chmst chmst mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants