Skip to content

[4.0] Fix README.md for unit tests#32935

Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom
richard67:4.0-dev-fix-typo-from-pr-32758
Mar 31, 2021
Merged

[4.0] Fix README.md for unit tests#32935
rdeutz merged 2 commits intojoomla:4.0-devfrom
richard67:4.0-dev-fix-typo-from-pr-32758

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Mar 30, 2021

Pull Request for Issue # .

Summary of Changes

  1. Fix typo phpunit-xml instead of phpunit.xml from PR Update README.md for unit tests #32758 .
  2. Remove the joomla-cms from paths in the description added by PR Update README.md for unit tests #32758 so that relative paths below the root folder of the checkout are used, like it is already for the given instructions "2. Run composer install in the root of your checkout." and "4. Run libraries/vendor/bin/phpunit".

I should have noticed that when reviewing that PR #32758 , but seems I was sleeping or blind.

Testing Instructions

Review.

Actual result BEFORE applying this Pull Request

Wong file name phpunit-xml instead of phpunit.xml used.

Inconsistent use of paths with and without the checkout root folder joomla-cms.

Expected result AFTER applying this Pull Request

Right file name phpunit.xml used.

Consistent use of relative paths below the checkout root folder`.

Documentation Changes Required

This is the documentation change.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on e87f892


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.

1 similar comment
@meinhoonharsh
Copy link

I have tested this item ✅ successfully on e87f892


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.

@alikon
Copy link
Contributor

alikon commented Mar 30, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev Unit/System Tests labels Mar 30, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Mar 31, 2021
@rdeutz rdeutz merged commit 90da53d into joomla:4.0-dev Mar 31, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2021
@richard67 richard67 deleted the 4.0-dev-fix-typo-from-pr-32758 branch March 31, 2021 17:45
@astridx
Copy link
Contributor

astridx commented Apr 2, 2021

@richard67 Thanks for correcting my PR.

dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants