[4.0] Fix README.md for unit tests#32935
Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom Mar 31, 2021
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on e87f892 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935. |
1 similar comment
|
I have tested this item ✅ successfully on e87f892 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935. |
Contributor
|
@richard67 Thanks for correcting my PR. |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
phpunit-xmlinstead ofphpunit.xmlfrom PR Update README.md for unit tests #32758 .joomla-cmsfrom paths in the description added by PR Update README.md for unit tests #32758 so that relative paths below the root folder of the checkout are used, like it is already for the given instructions "2. Runcomposer installin the root of your checkout." and "4. Runlibraries/vendor/bin/phpunit".I should have noticed that when reviewing that PR #32758 , but seems I was sleeping or blind.
Testing Instructions
Review.
Actual result BEFORE applying this Pull Request
Wong file name
phpunit-xmlinstead ofphpunit.xmlused.Inconsistent use of paths with and without the checkout root folder
joomla-cms.Expected result AFTER applying this Pull Request
Right file name
phpunit.xmlused.Consistent use of relative paths below the checkout root folder`.
Documentation Changes Required
This is the documentation change.