Merged
Conversation
As far as I can tell there is no module chrome for atum called "no" and this must have been intended to be "none" code review
Member
|
I have tested this item ✅ successfully on 04ae276 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32930. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 04ae276 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32930. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32930. |
dgrammatiko
reviewed
Mar 29, 2021
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| <jdoc:include type="modules" name="toolbar" style="no" /> | ||
| <jdoc:include type="modules" name="toolbar" style="none" /> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Style named none doesn't exist. This is the same as style="dimitris" (or any other word). Also should be a bit faster without a non-existing style as there are no IO operations trying to find something fictional
Contributor
There was a problem hiding this comment.
Ooops I/m wrong it seems that none is a thing
dgrammatiko
reviewed
Mar 29, 2021
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| <jdoc:include type="modules" name="toolbar" style="no" /> | ||
| <jdoc:include type="modules" name="toolbar" style="none" /> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32930. |
Contributor
|
Thanks! |
Contributor
Author
|
thx |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Apr 2, 2021
There is no module chrome for atum called "no" and this must have been intended to be "none"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell there is no module chrome for atum called "no" and this must have been intended to be "none"
code review