[4] deprecated iframe attributes#32913
Merged
richard67 merged 5 commits intojoomla:4.0-devfrom Mar 29, 2021
PhilETaylor:deprecatediframeattributes
Merged
[4] deprecated iframe attributes#32913richard67 merged 5 commits intojoomla:4.0-devfrom PhilETaylor:deprecatediframeattributes
richard67 merged 5 commits intojoomla:4.0-devfrom
PhilETaylor:deprecatediframeattributes
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Quy
reviewed
Mar 28, 2021
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Quy
reviewed
Mar 28, 2021
Co-authored-by: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on e59dbdc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913. |
Contributor
|
I have tested this item ✅ successfully on e59dbdc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913. |
Member
|
Thanks! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Apr 2, 2021
Co-authored-by: Quy <quy@fluxbb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32598
Replaces #32666 which was incomplete and 15 days without improvements
// cc @Megh05
Summary of Changes
Both the scrolling and frameborder are deprecated attributes, so I'd suggest removing these lines of code and also removing any associated parameters for them
Testing Instructions
Create some wrapper iframe and check the output HTML for the iframe tags
Actual result BEFORE applying this Pull Request
use of
scrollingandframeborderdeprecated tags, and associated paramsExpected result AFTER applying this Pull Request
no use of
scrollingandframeborderdeprecated tags, and associated paramsDocumentation Changes Required
none