Skip to content

[4.0] Atum badge borders#32951

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:badge
Apr 1, 2021
Merged

[4.0] Atum badge borders#32951
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:badge

Conversation

@brianteeman
Copy link
Contributor

Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border.

All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes.

This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses.

Testers dont forget to run npm to rebuild the css

The easies way to to check this would be in the article list after enabling the voting plugin

before

image

after

image

Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border.

All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes.

This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses.

Testers dont forget to run npm to rebuild the css

The easies way to to check this would be in the article list after enabling the voting plugin
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 31, 2021
@ceford
Copy link
Contributor

ceford commented Apr 1, 2021

I have tested this item ✅ successfully on 41fb0e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.

@Quy
Copy link
Contributor

Quy commented Apr 1, 2021

Wouldn't it better to remove the border? Why override Bootsrap badges when they look the same except for the border?

@meinhoonharsh
Copy link

I have tested this item ✅ successfully on 41fb0e8

## Before:
image

After:

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.

@brianteeman
Copy link
Contributor Author

Wouldn't it better to remove the border? Why override Bootsrap badges when they look the same except for the border?

I am not redesigning the template I am just fixing an obvious bug. From the code we can see that the intention was clearly to have a border but it ended up invisible

@Quy
Copy link
Contributor

Quy commented Apr 1, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Apr 1, 2021
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2021
@Quy Quy added this to the Joomla 4.0 milestone Apr 1, 2021
@Quy Quy merged commit ff82a45 into joomla:4.0-dev Apr 1, 2021
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Apr 1, 2021
@Quy
Copy link
Contributor

Quy commented Apr 1, 2021

Thanks.

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the badge branch April 1, 2021 17:23
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Apr 2, 2021
Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border.

All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes.

This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses.

Testers dont forget to run npm to rebuild the css

The easies way to to check this would be in the article list after enabling the voting plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants