Merged
Conversation
Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border. All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes. This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses. Testers dont forget to run npm to rebuild the css The easies way to to check this would be in the article list after enabling the voting plugin
Contributor
|
I have tested this item ✅ successfully on 41fb0e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951. |
Contributor
|
Wouldn't it better to remove the border? Why override Bootsrap badges when they look the same except for the border? |
|
I have tested this item ✅ successfully on 41fb0e8 After:This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951. |
Contributor
Author
I am not redesigning the template I am just fixing an obvious bug. From the code we can see that the intention was clearly to have a border but it ended up invisible |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951. |
Contributor
|
Thanks. |
Contributor
Author
|
thanks |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Apr 2, 2021
Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border. All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes. This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses. Testers dont forget to run npm to rebuild the css The easies way to to check this would be in the article list after enabling the voting plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border.
All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes.
This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses.
Testers dont forget to run npm to rebuild the css
The easies way to to check this would be in the article list after enabling the voting plugin
before
after