[4.0] Fixed empty blog class on update#32547
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 1, 2021
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 067bd89 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547. |
Contributor
|
I have tested this item ✅ successfully on 067bd89 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547. |
Contributor
|
Thanks! And oops - really should have spotted that || true on code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32493 .
Summary of Changes
This fixes two things:
|| truethat I used for debugging purposes in the making of [4.0] Upgrade column blog layouts to according CSS classes #31570 and accidentally committed (can be merged on code review).Testing Instructions
To test the PR, please start again with a clean beta-7 or nightly and then use the update package from this PR. This PR has no effect when updating an already updated site.
Actual result BEFORE applying this Pull Request
If you use an unpatched beta-7 update package, you will see notices like in #32493.
Expected result AFTER applying this Pull Request
Using the update package from this PR (see at the bottom "Show all checks" - "Download"), the notices should no longer appear.
Documentation Changes Required
none