Skip to content

Comments

[4.0] Fixed empty blog class on update#32547

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Harmageddon:fix_empty_blog_class
Mar 1, 2021
Merged

[4.0] Fixed empty blog class on update#32547
wilsonge merged 1 commit intojoomla:4.0-devfrom
Harmageddon:fix_empty_blog_class

Conversation

@Harmageddon
Copy link
Contributor

@Harmageddon Harmageddon commented Feb 28, 2021

Pull Request for Issue #32493 .

Summary of Changes

This fixes two things:

  1. A PHP notice that occurs under certain circumstances (see testing instructions).
  2. A || true that I used for debugging purposes in the making of [4.0] Upgrade column blog layouts to according CSS classes #31570 and accidentally committed (can be merged on code review).

Testing Instructions

  1. Install a clean beta-7 or nightly version.
  2. Set error reporting to development or maximum, don't make any other changes.
  3. Immediately after installation, run an update using an update package.

To test the PR, please start again with a clean beta-7 or nightly and then use the update package from this PR. This PR has no effect when updating an already updated site.

Actual result BEFORE applying this Pull Request

If you use an unpatched beta-7 update package, you will see notices like in #32493.

Expected result AFTER applying this Pull Request

Using the update package from this PR (see at the bottom "Show all checks" - "Download"), the notices should no longer appear.

Documentation Changes Required

none

@Harmageddon Harmageddon changed the title Fixed empty blog class on update. [4.0] Fixed empty blog class on update Feb 28, 2021
@jsubri
Copy link
Contributor

jsubri commented Mar 1, 2021

I have tested this item ✅ successfully on 067bd89

The 2 warnings are gone after applying the patch.
Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

@chmst
Copy link
Contributor

chmst commented Mar 1, 2021

I have tested this item ✅ successfully on 067bd89

Tested on win10, php8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 1, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 1, 2021
@wilsonge wilsonge merged commit 705ce67 into joomla:4.0-dev Mar 1, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 1, 2021
@wilsonge
Copy link
Contributor

wilsonge commented Mar 1, 2021

Thanks!

And oops - really should have spotted that || true on code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants