[4.0] Add display field attibute

[ciar4n]

Pull Request for Issue #32487 .

Summary of Changes

Because the 'class' XML attribute adds the class to the field itself rather than the outside container, it is not suitable for the classes added to #32422. This PR adds a parentclass attribute which adds a class to the outside control-group div.

Testing Instructions

Ensure #32422 works as described (updated to match)

Documentation Changes Required

[drmenzelit]

I have tested this item ✅ successfully on 7cef8cf

Tested in templateDetails.xml from Cassiopeia.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32488.}

[chmst]

I have tested in com_content, article.xml and there it works fine.

But in Options (config.xml) there is no effect.

[ciar4n]

@chmst Thank you for testing.

Strangely I am unable to replicate this issue. Adding to ..\administrator\components\com_config\forms\application.xml for example parentclass="span-2" works without issue.

[ciar4n]

@chmst My apologies. I see the issue now in component tabs as you said. I'll submit a fix.

[ciar4n]

@chmst Should be good now. 👍

[chmst]

I have tested this item ✅ successfully on 780fdc4

Tested wit com_content: article edit, com_content config.xml, com_users: user edit
and an own J4 component;
Documentation will be required. It is a great improvement. Thank you.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32488.}

[drmenzelit]

I have tested this item ✅ successfully on 780fdc4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32488.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32488.}

[korenevskiy]

1. Using the display attribute is confusing, because after the display you want to write block. Yes, in general, and parentclass is also not clear about which parent we are talking about. I suggest using the controlclass attribute, we know that in the full sense of the control is just <div class= "control-group"/>
2. I suggest making the layout multi-column. But with the observance of several rules. the note field and the spacer field will be full-width.
   Controls located between the note and spacer fields, only between them will be distributed in 2-3 columns. This will allow you not to create a garbage can from the fields. And of course the ability to use the controlclass attribute.
   But having the ability to override the default classes and set your own width in the number of columns.
   .
   In any case, now in Joomla Nightly 1 column mode, by analogy J3, looks better. 1 column is clearer and the most important thing is available. I propose to center 1 column in the middle.
   .
   How do I output a control-table without a Label?
   

[brianteeman]

hiddenLabel="true"

[infograf768]

@ciar4n

just a note: the code proposed is

if ($parentclass)
{
	$class .= ' ' . $parentclass;
}

As it already adds a space, we do not need the space in your example in #32422

<field
	name="article_layout"
	type="componentlayout"
	label="JFIELD_ALT_LAYOUT_LABEL"
	class="form-select"
	useglobal="true"
	extension="com_content"
	view="article"
        parentclass=" span-4 stack"
/>

also, I do not understand why, in this PR you add stack to the article layout in administrator/components/com_content/forms/article.xml as it does not have any effect.

https://github.com/joomla/joomla-cms/pull/32488/files#diff-48dcb2f2108f7b07952c9c407fd23cab28677e3d2fd437030b2f04a043282320R280-R286

[ciar4n]

@infograf768 My bad, I didn't mean to commit https://github.com/joomla/joomla-cms/pull/32488/files#diff-48dcb2f2108f7b07952c9c407fd23cab28677e3d2fd437030b2f04a043282320R280-R286 (reverted with cb121a5). The PR can remain in RTC as this class was ineffective.

And yes, no space is required in the example on #32422. I have edited this accordingly. Thanks for mentioning it!

[ciar4n]

@korenevskiy I guess the logic of parentclass is that this class is been added to the parent div of the field that the rule is creating. Unlike the class attribute, this does not add it to the control class div.

[korenevskiy]

@korenevskiy I guess the logic of parentclass is that this class is been added to the parent div of the field that the rule is creating. Unlike the class attribute, this does not add it to the control class div.

The control is < div class= "control-group" >. But the field is < input >. The field is located inside the control. The field has a parent that is a control. But the control also has a parent. It is intuitive for a layout designer who is unfamiliar with Joomla, but knows Bootstrap. ask which parent is being referred to when the class is specified, the parents of the control, or the parents of the field? But by specifying controlclass, it is clear that this is the class of the tag < div class="control group" > .

let the class be added directly to <div class= "control-group">
this will allow you to position the label at the same time.
Or can use another fieldclass class

[korenevskiy]

by the way, after all these tricks, the next step is this. 1. Creating an XML element to connect the CSS file to the form. 2. Create an XML tag to include Styles in the form.. Maybe this will be the right decision. This will be bad form for developers, but supporting such a feature is the right solution. I've seen modules where CSS is plugged in inside a custom field. This is worse than connecting directly to XML. but Joomla does not know how to do this.

You can consider a new attribute for <field>, such as <field type="text" css="my_module.css"/>

[korenevskiy]

@korenevskiy I guess the logic of parentclass is that this class is been added to the parent div of the field that the rule is creating. Unlike the class attribute, this does not add it to the control class div.

it is not clear from the name of the attribute which parent we are talking about
Not intuitive and unclear.
.
But <field controlclass="span-4 stack"> -> <div class= "control-group span-4 stack">
And now control will have a width across the entire GRID.

[ciar4n]

@korenevskiy As this PR is already set to RTC, I'll be unlikely to edit it further. Feel free to create a PR against this code once/if this gets merged 👍