Skip to content

Fix batch menu items#32380

Merged
infograf768 merged 1 commit intojoomla:stagingfrom
joomdonation:fix_batch_menu_items
Feb 11, 2021
Merged

Fix batch menu items#32380
infograf768 merged 1 commit intojoomla:stagingfrom
joomdonation:fix_batch_menu_items

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue #32375.

Summary of Changes

This small PR fixes #32375.

Testing Instructions

  1. Access to Menus -> Main Menu
  2. Select some menu items, then press Batch button in the toolbar
  3. Before patch: On then popup, you only see unpublished menu item
  4. After patch: Both published and unpublished menu items are being displayed

@toivo
Copy link
Contributor

toivo commented Feb 11, 2021

I have tested this item ✅ successfully on 641c3da

Tested successfully in 3.9.25-dev of 11 February in Wampserver 3.2.4 using PHP 8.0.1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32380.

@alikon
Copy link
Contributor

alikon commented Feb 11, 2021

I have tested this item ✅ successfully on 641c3da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32380.

@alikon
Copy link
Contributor

alikon commented Feb 11, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32380.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 11, 2021
@infograf768
Copy link
Member

Note: We have exactly the same issue in J4

@infograf768 infograf768 merged commit 4a6f30e into joomla:staging Feb 11, 2021
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Feb 11, 2021
@infograf768
Copy link
Member

Tks

@infograf768 infograf768 added this to the Joomla! 3.9.25 milestone Feb 11, 2021
@joomdonation joomdonation deleted the fix_batch_menu_items branch February 11, 2021 08:23
particthistle added a commit to particthistle/joomla-cms that referenced this pull request Mar 2, 2021
Issue resolved in "Fix batch menu items" joomla#32380 was applied to staging, but also affects 4.0-dev.

Changing the published option from $published to $this->state->get('filter.published') resolves it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch processing menu-items unable to select target menu-item

5 participants