[4] After authentication failure, return to the login page with a GET request#32897
Merged
rdeutz merged 3 commits intojoomla:4.0-devfrom Mar 30, 2021
PhilETaylor:faillogintoget
Merged
[4] After authentication failure, return to the login page with a GET request#32897rdeutz merged 3 commits intojoomla:4.0-devfrom PhilETaylor:faillogintoget
rdeutz merged 3 commits intojoomla:4.0-devfrom
PhilETaylor:faillogintoget
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
added 2 commits
March 28, 2021 17:56
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor
|
I have tested this item ✅ successfully on 5fe0333 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32897. |
Contributor
|
I have tested this item ✅ successfully on 5fe0333 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32897. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32897. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # #32895
Summary of Changes
After attempting to login with invalid credentials, you are not redirected back to the login page, so pressing refresh actually attempts to send the POST request a second time.
Administrator login form doesn't follow Post/Redirect/Get pattern
(also a quick typo fix in comment)
Testing Instructions
Attempt to login to Joomla 4 with invalid credentials.
Inspect the requests/responses with browser inspector tools
Actual result BEFORE applying this Pull Request
Request: POST of invalid credentials
Response: HTML with error message, if you refresh the page the browser asks to resend the form
Expected result AFTER applying this Pull Request
Request: POST of invalid credentials
Response: 303 Other redirect to /administrator/index.php
browser follows redirect (not always shown in the inspector on some browsers, look hard, it fooled me too)
Response: GET /administrator/index.php, if you refresh the page the browser just performs a refresh (GET) and validation message is missing as its already displayed
Documentation Changes Required
none