[4.0] Improve backend edit account#32947
Conversation
|
Ping @ceford since you reported the issue at #32933 (comment) |
|
For some reason this PR has no Test or diff buttons when accessed from Patchtester. And I don't know how return test result another way. I am happy and it is a pass. But I am not sure an Administrator should be allowed to set his own Status to blocked. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32947. |
Maybe you will have to click on Fetch Data to have Patch Tester fetches the new PRs. I still see the PRs listed (see the attached screenshot) There is another way to test if you cannot use patch tester. Just download the update package for this PR https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/32947/downloads/41449/Joomla_4.0.0-beta8-dev+pr.32947-Development-Update_Package.zip , go to System -> Update -> Joomla (the URL of that page looks like http://localhost/joomla4/administrator/index.php?option=com_joomlaupdate ), upload and install this update package. Then you can test it.
I have same question for this myself. I'm unsure if a user should be able to change his Status to Blocked. However, that's the current behavior of Joomla! and I don't want to touch it. For this PR, I just want to address the issue which you reported (make sense BTW). |
|
On submitting test result - in Patchtester I have done Reset and Fetch Data (twice). For this PR in the Joomla Issue Tracker I see this: In comparison to other PRs such as this: In the first example (this PR) the Diff link and Test this button are missing so I can't submit a test result. I have applied the patch and tested it but I don't know another way to return a result. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32947. |
|
@ceford Ah, Yes. I see. I could not see submit test result button in issue tracker, too, so strange. So have you tested this PR yet? If it is a success, maybe you can leave a comment here so that maintainer knows about it. |
|
👍 Works fine. (Submit test is not available in https://issues.joomla.org/tracker/joomla-cms/32947 ) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32947. |
|
👍 Works fine. Count this as a test Pass. |
|
Thanks @ceford and @infograf768 for testing. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32947. |
|
Thanks! |



Pull Request for Issue # .
Summary of Changes
PR #32771 allows users without core.manage permission to edit their own accounts directly via com_users instead of via view profile of com_admin (view profile later was removed via PR #32933)
However, it causes some changes when a manager edit his account:
This PR fixes that behavior. Basically, for users without core.manager permission, editing his account (now via com_users) should work the same as before (via com_admin)
Testing Instructions