[4][com_finder] Remove redundant sql query from running twice#32899
Merged
richard67 merged 1 commit intojoomla:4.0-devfrom Mar 29, 2021
PhilETaylor:patch-89
Merged
[4][com_finder] Remove redundant sql query from running twice#32899richard67 merged 1 commit intojoomla:4.0-devfrom PhilETaylor:patch-89
richard67 merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:patch-89
Conversation
Contributor
|
I have tested this item ✅ successfully on ab2c464 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899. |
Contributor
|
I have tested this item ✅ successfully on ab2c464 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899. |
Member
|
Thanks! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is clearly wrong on code review.
Testing Instructions
Enable debug mode
visit https://example.com/administrator/index.php?option=com_finder&view=index
inspect the db queries run
Actual result BEFORE applying this Pull Request
The following SQL query is run twice, once on
executeand once onloadResultExpected result AFTER applying this Pull Request
The following SQL query is run once, on
loadResultPage loads 2.53ms faster ;-)
Documentation Changes Required
none