Skip to content

[4][com_finder] Remove redundant sql query from running twice#32899

Merged
richard67 merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:patch-89
Mar 29, 2021
Merged

[4][com_finder] Remove redundant sql query from running twice#32899
richard67 merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:patch-89

Conversation

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Mar 28, 2021

Summary of Changes

This is clearly wrong on code review.

Testing Instructions

Enable debug mode
visit https://example.com/administrator/index.php?option=com_finder&view=index
inspect the db queries run

Actual result BEFORE applying this Pull Request

The following SQL query is run twice, once on execute and once on loadResult

SELECT COUNT(link_id)
FROM `jos_finder_links`

Screenshot 2021-03-28 at 18 58 00

Expected result AFTER applying this Pull Request

The following SQL query is run once, on loadResult

SELECT COUNT(link_id)
FROM `jos_finder_links`

Page loads 2.53ms faster ;-)

Documentation Changes Required

none

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on ab2c464


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.

@ceford
Copy link
Contributor

ceford commented Mar 29, 2021

I have tested this item ✅ successfully on ab2c464

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.

@Quy
Copy link
Contributor

Quy commented Mar 29, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 29, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 29, 2021
@richard67 richard67 merged commit ec5c72b into joomla:4.0-dev Mar 29, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 29, 2021
@richard67
Copy link
Member

Thanks!

dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants