Update joomla-image-select.css

[hitesh-coder]

Pull Request for Issue #31909.

Steps to reproduce

Content > Article
create a new article
click on cms-content dropdown select image
Click on any image additional data should popup

Summary of Changes

added a different background color and also added padding and border-radius which i thinks looks good

Expected result AFTER applying this Pull Request

This should make the necessary changes required for the desired styling

[infograf768]

Please post screenshots Before and After pr.

[hitesh-coder]

Before

After

@infograf768

[dgrammatiko]

Can you please also style the summary element (to look like a button or an accordion header)?

[hitesh-coder]

Updated as you asked @dgrammatiko

#BEFORE

#AFTER

[drmenzelit]

Can you use the same border-radius as in other places on template?

You have to check your PR, there are more changed files as needed. And the tests are failing (you can click on "Details" to see what is causing the problem)

[drmenzelit]

The css files should not be commited

[dgrammatiko]

@hitesh-coder sorry your changes need to be applied only on this file https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/css/fields/joomla-image-select.css

[hitesh-coder]

@dgrammatiko but you asked to change summary element as accordion header and that should be done in respective file
so should i now revert all my changes and apply as before

[brianteeman]

@hitesh-coder the problem is that your change is global and not just on this one element

[hitesh-coder]

AFTER

[ceford]

I have tested this item ✅ successfully on b5f790a

Better with this styling. Should it have a border?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.}

[meinhoonharsh]

I have not tested this item.

I tried to Test this, but when I Apply Patch, I can't see any change.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.}

[drmenzelit]

@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work

[hitesh-coder]

hey @ceford thanks for testing but could you please elaborate on the thing you mention I would love to make it better

[infograf768]

@hitesh-coder

add a border

joomla-field-mediamore details {
    position: absolute;
    background: #f5f5f5;
    border-radius: .25rem;
    border: 1px solid #c9c9c9; // add this
}

to get

[meinhoonharsh]

@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work

Thank You @drmenzelit , I will make sure to do this from now

[meinhoonharsh]

I have tested this item ✅ successfully on b5f790a

Before:

After:

[hitesh-coder]

hey @meinhoonharsh I have also added a border in my latest commit

[ceford]

I have tested this item ✅ successfully on 934c082

Yes - really nice with a border!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.}

[meinhoonharsh]

I have tested this item ✅ successfully on 934c082

I have Successfully tested this. It looks good in order to comparision with previous one

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.}

[drmenzelit]

@hitesh-coder why did you close this PR?

[hitesh-coder]

@drmenzelit I mistakenly deleted the branch while exploring GitHub feature. can I make another PR?

[richard67]

@hitesh-coder No need to make a new PR. I've re-opened this so it can be merged. This can be done even when you branch was deleted, as far as I know.

[drmenzelit]

Thanks!