Skip to content

[4.0] Delete unused password lang strings + update api joomla.ini#32546

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_useless-strings
Mar 3, 2021
Merged

[4.0] Delete unused password lang strings + update api joomla.ini#32546
Quy merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_useless-strings

Conversation

@infograf768
Copy link
Member

Pull Request for Issue #32506 (comment)

Summary of Changes

Delete 2 unused strings

JFIELD_PASSWORD_NOTE_DESC="%1 symbol(s), %2 uppercase letter(s), %3 lowercase letter(s), %4 number(s)"
JFIELD_PASSWORD_NOTE_LBL="Password must contain:"

Also updating api joomla.ini which should be in sync with administrator joomla.ini

Can be merged on review.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 28, 2021
@brianteeman
Copy link
Contributor

This is as a result of #30473

@particthistle
Copy link
Member

I have tested this item ✅ successfully on 8729603

I concur that I can't find the strings proposed to be removed in use anywhere else.
Additions to API Joomla.ini also look correct.

I'll get some more language string education later to work out why there needs to be api/language/en-GB/joomla.ini when all those strings are in language/en-GB/joomla.ini


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32546.

@toivo
Copy link
Contributor

toivo commented Mar 3, 2021

I have tested this item ✅ successfully on 8729603

Tested successfully in Beta8-dev of 3 March.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32546.

@infograf768 infograf768 removed Language Change This is for Translators PR-4.0-dev labels Mar 3, 2021
@infograf768
Copy link
Member Author

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32546.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2021
@infograf768 infograf768 added this to the Joomla 4.0 milestone Mar 3, 2021
@Quy Quy added the PR-4.0-dev label Mar 3, 2021
@Quy Quy merged commit 5185266 into joomla:4.0-dev Mar 3, 2021
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 3, 2021
@Quy
Copy link
Contributor

Quy commented Mar 3, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments