Upgrade to EUI v22.3.0 by chandlerprall · Pull Request #62963 · elastic/kibana

chandlerprall · 2020-04-08T15:53:02Z

Summary

`22.3.0`

Removed dependency on option list for custom option of EuiComboBox (#3183)
Fixed EuiPopover arrow position in Android and Linux (#3188)
Improved htmlIdGenerator when supplying both prefix and suffix (#3076)
Updated pagination prop descriptions for EuiInMemoryTable (#3142)
Added title and aria attributes to EuiToken's icon element (#3195)
Added new Elasticsearch token types (#2758)

Bug Fixes

Fixed bug in EuiAccordion to adjust to the correct height when content height changes (#3160)
Fixed bug in EuiBasicTable to handle dynamic icon value properly in collapsed actions (#3145)
Fixed availability check for actions in EuiBasicTable (3030)

`22.2.0`

Improved EuiModal close button position to prevent from overlapping with the title (#3176)

Bug Fixes

Removed outline of EuiSelect in Firefox ([adding feature to remove circles when option to remove circles selected #3197] (Removed moz border on focus from EuiSelect. eui#3197))
Fixed EuiBasicTable proptypes of itemId (#3133)
Updated EuiSuperDatePicker to inherit the selected value in quick select (#3105)

Feature: EuiCollapsibleNav (#3019)

Added EuiCollapsibleNav and EuiCollapsibleNavGroup components
Added EuiPinnableListGroup, an extension of EuiListGroup
Added ghost colored EuiListGroupItem, increased overall large size, and fixed focus states
Added color and size props to EuiListGroup
Added home and menu glyphs to EuiIcon
Added simple euiXScroll and euiYScroll SASS mixins and CSS utility equivelants

Bug Fixes

Fixed EuiAccordion icon margins, focus state, and flex issue in IE
Fixed 1.1px height of EuiHorizontalRule

`22.1.1`

Bug Fixes

Fixed infinite call stack in EuiResizeObserver's fallback polyfill (#3180)
Correct defaultProps definition in EuiComboBox (#3180)

`22.1.0`

Added delimiter prop to EuiComboBox (#3104)
Added useColorPickerState and useColorStopsState utilities (#3067)
Fixed EuiSearchBar related types (#3147)
Added prepend and append ability to EuiSuperSelect (#3167)

Bug Fixes

Fixed EuiNavDrawer scrolling issue on mobile (#3174)

`22.0.0`

Replaced various lodash functions with native functions (#3053)
Added whiteSpace prop to EuiCodeBlock (#3103)
Added sortMatchesBy prop for EuiComboBox (#3089)
Added prepend and append ability to EuiFieldPassword (#3122)
Added Enter key press functionality to EuiSuperDatePicker (#3048)
Added title to headers of EuiTable in case of truncation (#3094)
Added i18n to EuiTableHeaderCell (#3094)
Added number and string to size type of EuiImage for setting custom sizes (#3012)
Improved EuiButtonEmpty focus state when the color type is text (#3135)
Added EuiLoadingElastic component (#3017)
Upgraded react-beautiful-dnd to v13 (#3064)
Fixed EuiPagination vertical alignment of the text when used as compressed (#3152)
Added showTooltip prop for EuiSuperUpdateButton to show tooltip and showing only once popovers are closed (#3127)

Bug Fixes

Fixed bug in EuiSuperDatePicker not showing correct values in relative tab of end date (#3132)
Fixed bug in EuiSuperDatePicker to show correct values of commonly used values in relative tab (#3106)
Fixed race condition in EuiIcon when switching from dynamically fetched components (#3118)
Fixed the issue that EuiResizeObserver fallback did not properly listen to pure window resizing (#3088)

Breaking changes

Removed EuiKeyPadMenuItemButton in favor of just EuiKeyPadMenuItem that can also accept an onClick (#3062)

`21.1.0`

Updated EuiFilterSelect to retain the order of its filters (#3063)
Added href prop to EuiBadge (#3009)
Added props descriptions for EuiComboBox (#3007)
Exported dateFormatAliases as a part of the public API (#3043)
Exported EuiTextProps type definition (#3039)
Added a component prop to EuiForm to render a <form>(#3010)
Removed role attribute from EuiImage(#3036)
Added prepend and append ability to EuiComboBox single selection only (#3003)
Added onColumnResize prop to EuiDataGrid of type EuiDataGridOnColumnResizeHandler that gets called when column changes it's size (#2963)
Added logoEnterpriseSearch to EuiIcon (#3066)
Added RGB format support to EuiColorPicker and EuiColorStops (#2850)
Added alpha channel (opacity) support to EuiColorPicker and EuiColorStops (#2850)
Added useResizeObserver hook (#2991)
Added showColumnSelector.allowHide and showColumnSelector.allowReorder props to EuiDataGrid UI configuration (#2993)
Added EuiMark component (#3060)
Changed tabs.name prop shape in EuiTabbedContent to accept a node, which aligns it with EuiTab (#3100)

Bug Fixes

Fixed EuiFieldNumber so values of type number are now allowed (#3020)
Fixed SASS contrastRatio() function in dark mode by fixing the pow() math function ([[settings/objects] fixed the saved object editor #3013], (Bug fix in contrastRatio function eui#3013))
Fixed bug preventing EuiDataGrid from re-evaluating the default column width on resize (#2991)
Fixed padding in EuiCallOut when used as a banner for EuiFlyout (#3098)

chandlerprall · 2020-04-09T19:29:53Z

xpack-siemCypress test is failing due to yarn's installation of workspace dependencies. @spalger is investigating (❤️)

…ode_modules to hold its correct version

legrego

Security changes LGTM - code review only

spalger

Operations: LGTM

pgayvallet

LGTM for platform changes

...aved_objects_management/public/management_section/objects_table/components/relationships.tsx

mikecote

Alerting code LGTM

chrisronline

I don't see any changes for the monitoring plugin

poffdeluxe

I'm getting a few errors when loading up Canvas that aren't present on master. Chrome logs an error to console and Firefox throws up a caught error message in the Canvas app. The logged error isn't super helpful cuz it's throwing the error that's happening while handling a different error.

The error it's trying to handle is ResizeObserver loop limit exceeded

…anvas

poffdeluxe

Canvas changes lgtm!

smith

APM changes look ok.

...p/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/SpanFlyout/index.tsx

lizozom

LGTM

peteharverson

ML LGTM - also gave it a quick visual test locally.

chandlerprall · 2020-04-21T17:29:30Z

jenkins test this

rylnd

SIEM changes LGTM. Sorry about the snapshot noise! A followup on the as anys would be appreciated as well, but I understand the limitations are between EUI and styled-components.

...cy/plugins/siem/public/components/notes/note_card/__snapshots__/note_card_body.test.tsx.snap

kibanamachine · 2020-04-22T16:51:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a91ff36

History

💚 Build #42221 succeeded 3b0a30b
💚 Build #41983 succeeded 0bba8a6
💚 Build #41690 succeeded 9e6c609
💚 Build #41668 succeeded bca5d51
💛 Build #41596 was flaky c92a75d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* snapshot updates * bump to eui 22.3.0 * snapshots * Fix css selector in test to match EUI internal DOM change * Updated snapshots * Insert react-beautiful-dnd@10 into top-level kibana to force siem's node_modules to hold its correct version * More snapshot updates, resolved a typescript issue * Move react-beautiful-dnd dependency around to make things happy again * Use SearchFilterConfig from the top-level eui export * Swallow 'ResizeObserver error does not have an err object' error in canvas * Swallow ResizeObserver error cross-browser

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 8, 2020

chandlerprall mentioned this pull request Apr 8, 2020

Upgrade to EUI v22.1.1 #62065

Closed

chandlerprall force-pushed the eui-22-3-0 branch from 1c0828e to 27b6d9a Compare April 8, 2020 20:53

chandlerprall force-pushed the eui-22-3-0 branch 2 times, most recently from d5d7267 to f126ee8 Compare April 15, 2020 17:07

chandlerprall added 8 commits April 16, 2020 08:24

snapshot updates

13fbe2e

bump to eui 22.3.0

35ab7ae

snapshots

df6079e

Fix css selector in test to match EUI internal DOM change

148840a

Updated snapshots

b024db0

Insert react-beautiful-dnd@10 into top-level kibana to force siem's n…

d3f43fa

…ode_modules to hold its correct version

More snapshot updates, resolved a typescript issue

6fdf15c

Move react-beautiful-dnd dependency around to make things happy again

9451914

chandlerprall force-pushed the eui-22-3-0 branch from f126ee8 to 9451914 Compare April 16, 2020 19:41

chandlerprall marked this pull request as ready for review April 16, 2020 21:32

chandlerprall requested a review from a team April 16, 2020 21:32

chandlerprall requested a review from a team as a code owner April 16, 2020 21:32

chandlerprall requested a review from a team April 16, 2020 21:32

chandlerprall requested review from a team as code owners April 16, 2020 21:32

chandlerprall requested a review from a team April 16, 2020 21:32

legrego approved these changes Apr 16, 2020

View reviewed changes

spalger approved these changes Apr 16, 2020

View reviewed changes

pgayvallet approved these changes Apr 17, 2020

View reviewed changes

...aved_objects_management/public/management_section/objects_table/components/relationships.tsx Outdated Show resolved Hide resolved

mikecote approved these changes Apr 17, 2020

View reviewed changes

chrisronline approved these changes Apr 17, 2020

View reviewed changes

Use SearchFilterConfig from the top-level eui export

c92a75d

poffdeluxe suggested changes Apr 17, 2020

View reviewed changes

chandlerprall added 2 commits April 17, 2020 12:56

Swallow 'ResizeObserver error does not have an err object' error in c…

bca5d51

…anvas

Swallow ResizeObserver error cross-browser

9e6c609

poffdeluxe approved these changes Apr 17, 2020

View reviewed changes

smith approved these changes Apr 17, 2020

View reviewed changes

...p/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/SpanFlyout/index.tsx Show resolved Hide resolved

lizozom reviewed Apr 19, 2020

View reviewed changes

lizozom approved these changes Apr 19, 2020

View reviewed changes

elastic deleted a comment from elasticmachine Apr 19, 2020

chandlerprall added 2 commits April 20, 2020 11:20

Merge branch 'master' into eui-22-3-0

0bba8a6

Merge branch 'master' into eui-22-3-0

3b0a30b

peteharverson approved these changes Apr 21, 2020

View reviewed changes

rylnd mentioned this pull request Apr 21, 2020

[SIEM] Snapshot tests include Eui ThemeProvider #64092

Closed

rylnd approved these changes Apr 21, 2020

View reviewed changes

...cy/plugins/siem/public/components/notes/note_card/__snapshots__/note_card_body.test.tsx.snap Show resolved Hide resolved

Merge branch 'master' into eui-22-3-0

a91ff36

chandlerprall merged commit 126d187 into elastic:master Apr 22, 2020

chandlerprall deleted the eui-22-3-0 branch April 22, 2020 17:02

chandlerprall mentioned this pull request Apr 22, 2020

[7.x] Upgrade to EUI v22.3.0 (#62963) #64222

Merged

rylnd mentioned this pull request Apr 22, 2020

[SIEM] Client NP Cutover #64251

Merged

4 tasks

chandlerprall mentioned this pull request Apr 27, 2020

Replace a number of any-ed styled(eui*) with accurate types #64555

Merged

Conversation

chandlerprall commented Apr 8, 2020

Summary

22.3.0

22.2.0

Feature: EuiCollapsibleNav (#3019)

22.1.1

22.1.0

22.0.0

21.1.0

Uh oh!

chandlerprall commented Apr 9, 2020

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

chandlerprall commented Apr 21, 2020

Uh oh!

rylnd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Apr 22, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

`22.3.0`

`22.2.0`

`22.1.1`

`22.1.0`

`22.0.0`

`21.1.0`

chrisronline left a comment •

edited

Loading

poffdeluxe left a comment •

edited

Loading