EuiFilterSelect now retains the order of filters#3063
EuiFilterSelect now retains the order of filters#3063chandlerprall merged 4 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3063/ |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; tested locally, including modifying the search bar example's options to a synchronous object instead of the async promise
|
CI ran out of memory, tests pass without issue for me but re-executing the CI suite to test if there's something introduced by this PR. jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3063/ |
|
CI passed that time around, calling this good! |
3 participants
Summary
Fixed: #1371
EuiFilterSelectnow retains the order of filtersChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes