Skip to content

Adding prepend and append to EuiSuperSelect#3167

Merged
elizabetdev merged 6 commits intoelastic:masterfrom
elizabetdev:super-select-append-prepend
Mar 26, 2020
Merged

Adding prepend and append to EuiSuperSelect#3167
elizabetdev merged 6 commits intoelastic:masterfrom
elizabetdev:super-select-append-prepend

Conversation

@elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Mar 25, 2020

Summary

This PR adds a prepend and append to EuiSuperSelect. And it's required to finish the EuiColorPalettePicker.

It can be tested in the Super Select States section of the docs.

Screenshot 2020-03-25 at 20 25 50

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested a review from cchaos March 25, 2020 20:27
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3167/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! Docs work as expected

@cchaos
Copy link
Contributor

cchaos commented Mar 25, 2020

Hmm, it looks like adding that overflow:hidden also hide the shadow:

Before
Screen Shot 2020-03-25 at 18 01 35 PM

After
Screen Shot 2020-03-25 at 18 01 21 PM

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3167/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3167/

@elizabetdev
Copy link
Contributor Author

Hi @cchaos,

I tried a different approach. Now I'm adding the overflow: hidden to the .euiFormControlLayout__childrenWrapper only when the prepend/append is true.

I also added a test.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3167/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think the PR is out of date with master as the Changelog is incorrect.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3167/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants