Added option to wrap lines in EuiCodeBlock by anishagg17 · Pull Request #3103 · elastic/eui

anishagg17 · 2020-03-17T10:28:50Z

Summary

Fixes : #1501

Screenshot

wrapLines : nowrap

Checklist

~~- [ ] Check against all themes for compatibility in both light and dark modes~~
- [ ] Checked in mobile

Checked in IE11 and Firefox
Props have proper autodocs
Added documentation examples
Added or updated jest tests
~~- [ ] Checked for breaking changes and labeled appropriately~~
~~- [ ] Checked for accessibility including keyboard-only and screenreader modes~~
A changelog entry exists and is marked appropriately

kibanamachine · 2020-03-17T10:28:52Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elizabetdev · 2020-03-17T14:46:14Z

jenkins test this

kibanamachine · 2020-03-17T15:05:56Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

snide

Couple changes. Thanks for taking on this issue.

src/components/code/_code_block.tsx

elizabetdev

Thanks for creating this PR. I tested locally and I added a few comments.

Also, don't forget to go through our checklist. It's very important to make sure it works on IE11 and Firefox. 🙂

src/components/code/_code_block.scss

src/components/code/_code_block.tsx

CHANGELOG.md

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

anishagg17 · 2020-03-18T12:07:18Z

Thanks @miukimiu

src/components/code/_code_block.tsx

elizabetdev · 2020-03-18T16:13:54Z

Hi @anishagg17,

I just did a PR with a few changes anishagg17#5.

The CSS classes should respect the BEM naming convention.
I also changed the description text and added some code highlights

Can you approve the PR?

elizabetdev

Thanks @anishagg17! LGTM! 🎉

cchaos

Looking better, but still needs a test and a doc example for showing the non-default case of pre.

anishagg17 · 2020-03-18T16:43:32Z

I will add It

anishagg17 · 2020-03-19T19:10:08Z

All changes have been made

cchaos · 2020-03-20T16:35:51Z

Jenkins test this

src-docs/src/views/code/code_block_pre.js

src/components/code/_code_block.test.tsx

kibanamachine · 2020-03-20T16:54:33Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

elizabetdev · 2020-03-20T17:42:02Z

jenkins test this

kibanamachine · 2020-03-20T18:01:07Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

src-docs/src/views/code/code_block_pre.js

elizabetdev · 2020-03-20T18:26:12Z

jenkins test this

kibanamachine · 2020-03-20T18:46:34Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

elizabetdev · 2020-03-23T17:08:39Z

Hi @anishagg17,

I found one more issue. The src-docs/src/views/code/code_block_pre.js example was missing a whiteSpace="pre". I also improved the text.

Here's the PR: anishagg17#8

anishagg17 · 2020-03-23T18:08:07Z

Pr merged 👍

elizabetdev · 2020-03-23T18:15:55Z

jenkins test this

kibanamachine · 2020-03-23T18:33:19Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

elizabetdev

LGTM! 🎉

You just need to merge master and update the tests because the build is failing.

anishagg17 · 2020-03-23T20:10:16Z

I have merged master , now I think build would pass

elizabetdev · 2020-03-23T20:10:48Z

jenkins test this

kibanamachine · 2020-03-23T20:29:56Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3103/

snide · 2020-03-23T20:59:11Z

Thanks @anishagg17! Double checked my earlier issues and merged before the CL got out of date.

added option to wrap lines in euicodeblock

d3ded83

Merge branch 'master' into wrap

5183e62

cchaos changed the title ~~added option to wrap lines in euicodeblock~~ Added option to wrap lines in EuiCodeBlock Mar 17, 2020

elizabetdev self-requested a review March 17, 2020 13:12

snide suggested changes Mar 17, 2020

View reviewed changes

src/components/code/_code_block.tsx Outdated Show resolved Hide resolved

anishagg17 and others added 3 commits March 18, 2020 12:57

Merge branch 'master' into wrap

af3d8e8

Update CHANGELOG.md

6a5e406

replaced prop name

d51d5c2

elizabetdev suggested changes Mar 18, 2020

View reviewed changes

src/components/code/_code_block.scss Outdated Show resolved Hide resolved

src/components/code/_code_block.tsx Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

anishagg17 and others added 3 commits March 18, 2020 17:36

Update src/components/code/_code_block.scss

62f7d61

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

Update src/components/code/_code_block.tsx

ac9134c

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

Update CHANGELOG.md

e6c2845

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

elizabetdev reviewed Mar 18, 2020

View reviewed changes

src/components/code/_code_block.tsx Outdated Show resolved Hide resolved

elizabetdev reviewed Mar 18, 2020

View reviewed changes

src/components/code/_code_block.tsx Outdated Show resolved Hide resolved

used scss modifiers

2b8ce4a

Minor fixes (#5)

a5c4cca

elizabetdev approved these changes Mar 18, 2020

View reviewed changes

elizabetdev requested a review from cchaos March 18, 2020 16:28

cchaos reviewed Mar 18, 2020

View reviewed changes

anishagg17 and others added 4 commits March 18, 2020 22:36

added test, docs example

b444fb2

added pre example

b7035c8

Merge branch 'master' into wrap

15484ca

Merge branch 'master' into wrap

7831586

elizabetdev suggested changes Mar 20, 2020

View reviewed changes

src-docs/src/views/code/code_block_pre.js Outdated Show resolved Hide resolved

src/components/code/_code_block.test.tsx Outdated Show resolved Hide resolved

anishagg17 and others added 2 commits March 20, 2020 22:45

Update src-docs/src/views/code/code_block_pre.js

f8bf65c

Co-Authored-By: Elizabet Oliveira <elizabet.oliveira@elastic.co>

updated test

8dd0cbf

elizabetdev reviewed Mar 20, 2020

View reviewed changes

src-docs/src/views/code/code_block_pre.js Outdated Show resolved Hide resolved

fixed indent

894afd2

Improving text and example (#8)

fc99765

elizabetdev approved these changes Mar 23, 2020

View reviewed changes

anishagg17 added 2 commits March 24, 2020 01:20

Merge branch 'master' of https://github.com/elastic/eui into wrap

22fb9a0

Merge branch 'wrap' of https://github.com/anishagg17/eui into wrap

30e4407

snide approved these changes Mar 23, 2020

View reviewed changes

snide merged commit 1eece3d into elastic:master Mar 23, 2020

anishagg17 deleted the wrap branch March 23, 2020 21:24

chandlerprall mentioned this pull request Mar 31, 2020

Upgrade to EUI v22.1.1 elastic/kibana#62065

Closed

chandlerprall mentioned this pull request Apr 8, 2020

Upgrade to EUI v22.3.0 elastic/kibana#62963

Merged

Conversation

anishagg17 commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshot

Checklist

Uh oh!

kibanamachine commented Mar 17, 2020

Uh oh!

elizabetdev commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 17, 2020

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elizabetdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anishagg17 commented Mar 18, 2020

Uh oh!

Uh oh!

Uh oh!

elizabetdev commented Mar 18, 2020

Uh oh!

elizabetdev left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

anishagg17 commented Mar 18, 2020

Uh oh!

anishagg17 commented Mar 19, 2020

Uh oh!

cchaos commented Mar 20, 2020

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 20, 2020

Uh oh!

elizabetdev commented Mar 20, 2020

Uh oh!

kibanamachine commented Mar 20, 2020

Uh oh!

Uh oh!

elizabetdev commented Mar 20, 2020

Uh oh!

kibanamachine commented Mar 20, 2020

Uh oh!

elizabetdev commented Mar 23, 2020

Uh oh!

anishagg17 commented Mar 23, 2020

Uh oh!

elizabetdev commented Mar 23, 2020

Uh oh!

kibanamachine commented Mar 23, 2020

Uh oh!

elizabetdev left a comment

Choose a reason for hiding this comment

Uh oh!

anishagg17 commented Mar 23, 2020

Uh oh!

elizabetdev commented Mar 23, 2020

Uh oh!

kibanamachine commented Mar 23, 2020

Uh oh!

snide commented Mar 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

anishagg17 commented Mar 17, 2020 •

edited

Loading