Inherit commonly used data on relative tab on EuiSuperDatePicker#3106
Inherit commonly used data on relative tab on EuiSuperDatePicker#3106thompsongl merged 6 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3106/ |
cchaos
left a comment
There was a problem hiding this comment.
This does appear to fix the issue. 👍 I'd like @thompsongl to do a quick review of the code.
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3106/ |
thompsongl
left a comment
There was a problem hiding this comment.
This does fix the 0 seconds ago problem, but highlights a different problem:
The end date popover shows the same relative time as the start date popover ("now" is fine)
I don't think this is directly related to the issue at hand, so I'll investigate some more but likely open a new issue, allowing this to merge
@thompsongl I got two possible fixes
Do I have to push that changes or create another PR for the same? |
If you think you have a fix already, go ahead and push to this branch. For what it's worth, the only problem seems to be with "Relative" dates in the "End date" popover; absolute and now are fine, as is everything in the "Start date" popover |
|
@thompsongl Thanks for the suggestion. My fix doesn't work. I will investigate further on this issue 👍 |
|
Thanks, @ashikmeerankutty I'll likely merge this and open an new issue. Feel free to continue work in a new PR if you come upon a fix. |
|
#3131 covers the new case discovered after the fix in this PR |

Summary
Fixes #1600
Fixed inherit commonly used data on the relative tab on EuiSuperDatePicker
From
To
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes