Pass title and aria attributes to EuiToken's icon element#3195
Pass title and aria attributes to EuiToken's icon element#3195cchaos merged 6 commits intoelastic:masterfrom
EuiToken's icon element#3195Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
The test is a little deceptive because it puts the aria-label on div but pulling down the branch, it correctly renders on the svg when actually being rendered. (I think this is just due to how the icon test rendering works.)
LGTM
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
This still needs a changelog entry, but otherwise looks good.
thompsongl
changed the title
EuiToken's icon element
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Minor nits on language. I'll commit them
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
5 participants
Summary
#3182
aria-label, aria-labelledby, aria-describedby, title is now added to EuiToken
Checklist
~~Check against all themes for compatibility in both light and dark modes
~~Checked in mobile
Added documentation examples