Fixed bug in EuiBasicTable to handle dynamic icon value properly in collapsed actions#3145
Fixed bug in EuiBasicTable to handle dynamic icon value properly in collapsed actions#3145chandlerprall merged 5 commits intoelastic:masterfrom
EuiBasicTable to handle dynamic icon value properly in collapsed actions#3145Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@crux153 Can you please give more explanation in the summary? |
|
@cchaos I updated the summary. Thanks! |
chandlerprall
left a comment
There was a problem hiding this comment.
Nice! Thanks for digging into this and finding the root cause. I've asked for two small changes, otherwise this looks great.
|
@chandlerprall I just copied the implementation detail from existing DefaultItemAction component. I love your setup as it is much cleaner than before, so I applied the same changes to both components. Thank you :) |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3145/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks for tracking down the root cause, and the extra cleanup on this one!
Summary
Fix for #3144
While
DefaultItemActionaccepts a function to dynamically change icon value as like below,It crashes when shown in
CollapsedItemActionscomponent, since the logic to handle functional icon prop is present only inDefaultItemActionand missing inCollapsedItemActions.If I pass an action with dynamic icon value like above, the table crashes when clicking the expand button in action column.
This PR adds the missing handler to
CollapsedItemActionsso that it works in the same way asDefaultItemActiondoes.Checklist