[EuiComboBox] Added sortMatchesBy prop#3089
Conversation
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
@anishagg17 You'll still need to update the docs with the new prop name and add tests. |
|
I have already updated docs with an example showing startsWith property This test has some linting error can you please help me by fixing it
|
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Jenkins, test this |
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
These will get the tests working.
There's also an eslint error in src-docs/src/views/combo_box/combo_box_example.js that you'll want to fix
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3089/ |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
This looks great! Thanks!
cchaos
changed the title
sortMatchesBy prop
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @anishagg17
Just need to fix the merge conflict
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3089/ |
4 participants
Summary
Fixes: #1767 & Fixes #652
added startingWith prop to combobox, it can be seen in action on the last combobox demo in the view section
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes