Fix padding in EuiCallout when used as banner for EuiFlyout#3098
Merged
andreadelrio merged 3 commits intoelastic:masterfrom Mar 17, 2020
Merged
Fix padding in EuiCallout when used as banner for EuiFlyout#3098andreadelrio merged 3 commits intoelastic:masterfrom
andreadelrio merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3098/ |
cchaos
reviewed
Mar 17, 2020
Contributor
|
I also un-strike-throughed a couple of checklist items that, even though it's a small change, should get double-checked "just in case". |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3098/ |
cchaos
approved these changes
Mar 17, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Btw, thank you for fixing this one. I saw the screenshots in the Kibana PR, and thought to myself "That alignment is gonna irk me". 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the content of a callout with the content of EuiFlyoutHeader
Before
After
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes