[EuiFieldNumber] Add string as valid value type#3020
Merged
thompsongl merged 7 commits intomasterfrom Mar 10, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3020/ |
thompsongl
reviewed
Mar 10, 2020
Co-Authored-By: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
Member
Author
|
@dimitropoulos @thompsongl Done! :) |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3020/ |
thompsongl
suggested changes
Mar 10, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @sqren!
Can you please add a changelog entry for this?
Member
Author
|
@thompsongl I added it as a bug fix. Not sure if that's the right classification. LMK if I should change it. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3020/ |
thompsongl
approved these changes
Mar 10, 2020
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
stringas a type forvaluein theEuiFieldNumbercomponent.Reasoning
There's nothing wrong with supplying a serialized number (eg. "40") to an input field, since it'll be serialized anyway. When the
onChangehandler is callede.target.valuewill likewise be of typestringregardless what the input type was.This will remove the need for serializing/deserializing numbers when working with
EuiFieldNumberImpact
This won't change much, other than removing an error in the console when supplying a string: