Updated pagination prop descriptions for EuiInMemoryTable#3142
Merged
cchaos merged 10 commits intoelastic:masterfrom Mar 30, 2020
Merged
Updated pagination prop descriptions for EuiInMemoryTable#3142cchaos merged 10 commits intoelastic:masterfrom
EuiInMemoryTable#3142cchaos merged 10 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Contributor
Author
|
cla/check |
Contributor
|
Jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3142/ |
cchaos
suggested changes
Mar 24, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks @walnutdust. Just a couple minor things
Contributor
|
jenkins test this |
cchaos
approved these changes
Mar 25, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks for clearing those up for me. 👍
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3142/ |
cchaos
reviewed
Mar 25, 2020
cchaos
changed the title
EuiInMemoryTable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per the discussion in #435 ,
Checklist
Added documentation examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes