[EuiTable] Added title to headers in case of truncation#3094
Merged
cchaos merged 11 commits intoelastic:masterfrom Mar 19, 2020
Merged
[EuiTable] Added title to headers in case of truncation#3094cchaos merged 11 commits intoelastic:masterfrom
title to headers in case of truncation#3094cchaos merged 11 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
chandlerprall
suggested changes
Mar 16, 2020
Contributor
|
Jenkins, test this Don't forget a changelog entry |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3094/ |
cchaos
reviewed
Mar 16, 2020
Contributor
|
@anishagg17 I realized that we have a lot of straight strings in this file that need to be internationalized. So I created a PR for you: anishagg17#4 |
Contributor
|
jenkins, test this |
cchaos
reviewed
Mar 18, 2020
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3094/ |
cchaos
changed the title
title to headers in case of truncation
Contributor
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3094/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #913
Screenshot
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes