added enter key functionality#3048
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
src/components/date_picker/super_date_picker/super_date_picker.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/super_date_picker.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/super_date_picker.js
Outdated
Show resolved
Hide resolved
chandlerprall
left a comment
There was a problem hiding this comment.
Functionality works as desired; have some feedback on the code changes
src/components/date_picker/super_date_picker/__snapshots__/super_date_picker.test.js.snap
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
|
@myasonik can you please review the change of Alternative would be to pass the |
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3048/ |
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
…ver/refresh_interval.js Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
|
All changes have been made |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3048/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; thanks for iterating on this one @anishagg17 !

Summary
Fixes : #3033
added enter key functionality in eui super date picker
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately