Skip to content

[EuiNavDrawer] Fix scrolling in mobile view#3174

Merged
cchaos merged 4 commits intoelastic:masterfrom
lokeshrana9999:current
Mar 27, 2020
Merged

[EuiNavDrawer] Fix scrolling in mobile view#3174
cchaos merged 4 commits intoelastic:masterfrom
lokeshrana9999:current

Conversation

@lokeshrana9999
Copy link
Contributor

@lokeshrana9999 lokeshrana9999 commented Mar 26, 2020

Summary

#3143
NavDrawer didn't scroll in mobile view. Problem solved using respective css selectors to modify flex-wrap property.
ezgif-4-261b86f08eb8

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@lokeshrana9999 lokeshrana9999 marked this pull request as ready for review March 26, 2020 12:05
@cchaos
Copy link
Contributor

cchaos commented Mar 26, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3174/

@chandlerprall chandlerprall requested a review from cchaos March 26, 2020 17:22
@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3174/

@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2020

Looks like you need to update the snapshots. You'll need to run yarn run test-unit -u. I updated the checklist of in the PR summary for things that still need to be checked off.

@cchaos cchaos changed the title Navdrawer scrollable in mobile view [EuiNavDrawer] Fix scrolling in mobile view Mar 27, 2020
…p instead of css selectors and respective snapshot updated
@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3174/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in Chrome's emulator and it works now!

@cchaos cchaos merged commit 1bc6b4a into elastic:master Mar 27, 2020
elizabetdev pushed a commit to elizabetdev/eui that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants