Add logo Enterprise Search to EuiIcon#3066
Merged
elizabetdev merged 5 commits intoelastic:masterfrom Mar 13, 2020
Merged
Conversation
Contributor
Author
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/ |
snide
approved these changes
Mar 13, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Yep. Remove the deprecation warning.
cchaos
reviewed
Mar 13, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Ahh wait, I think we need a changelog too
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2937
The
logoEnterpriseSearchwas previously renamed tologoWorkplaceSearchto match the product rename. And there's a deprecation scheduled on #1469:logoEnterpriseSearchtype deprecated in favor oflogoWorkplaceSearchBut there's the necessity of adding a new
logoEnterpriseSearchto match the solution (which encompasses the workplace search, app search, and site search products).In this PR I'm adding the new logo.
Figma Design
Light and Dark themes
Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes