Add Elastic logo loading component#3017
Merged
mdefazio merged 5 commits intoelastic:masterfrom Mar 20, 2020
Merged
Conversation
snide
reviewed
Mar 18, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Sorry for the late review. I saw this in a draft state so didn't check it early. Some small comments. The animation is really nice. 🎉
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/ |
snide
approved these changes
Mar 20, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Don't forget to add a changelog.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/ |
Contributor
|
Gonna help @mdefazio get this branch cleaned up before merging. |
mdefazio
force-pushed
the
loading-elastic-icon
branch
from
391c4c4 to
1e56818
Compare
6 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3017/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an Elastic animated loading indicator.
Note: Potential animation performance issues noticed in some usages.
Checklist
Checked in mobileAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes