Fix EuiResizeObserver and EuiComboBox bugs#3180
Merged
thompsongl merged 4 commits intoelastic:masterfrom Mar 27, 2020
Merged
Conversation
…Props setup in EuiComboBox
chandlerprall
force-pushed
the
bug/eui-22-1-0-bugs
branch
from
953ea47 to
4aaa572
Compare
myasonik
approved these changes
Mar 26, 2020
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
✅ (Mostly a rubber stamp approval as we paired on these bugs)
thompsongl
approved these changes
Mar 26, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @chandlerprall!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3180/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3180/ |
elizabetdev
pushed a commit
to elizabetdev/eui
that referenced
this pull request
Mar 30, 2020
* Fixed EuiResizeObserver infinite disconnect call chain; fixed defaultProps setup in EuiComboBox * changelog Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while upgrading Kibana.
EuiResizeObserver's mutation observer fallback disconnect method calls itself infinitelyEuiComboBoxhad two errors around itsdefaultPropsChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes