Merged
Conversation
…der runtime guard (#18460) Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>
Commit Message: If request/response has content-length header, its value must be the equal to the actually body length. Otherise reset the stream as nghttp2 does. Risk Level: low Testing: added integration tests Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This causes the ALPN/mixed pool to not raise the failure reason to the router. Signed-off-by: Matt Klein <mklein@lyft.com>
Make Server::Options available to the SSL handshaker factory Additional Description: This allows the handshaker to detect the run mode (`Server::Options::mode`) and use that to bypass checks required for serving but not for validation. Risk Level: low Testing: added and ran unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Konradi <akonradi@google.com>
Fixes #18434 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Disabling the tests as they reduce the CI reliability. Opened an issue for tracking Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
This is hard to detect because Envoy doesn't use FMT_STRING, which would do compile-time checking of formats. It should be logged to stderr by default by spdlog, but I'm not seeing those logs anywhere when running the ext_authz tests. Risk Level: low Testing: Ran the ext_authz tests, verified that the log message appears. Signed-off-by: Michael Leuchtenburg <mleuchtenburg@google.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Taylor Barrella <tabarr@google.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
…18512) Commit Message: Add zone response metrics to thrift upstream requests Additional Description: Add response type/reply type counters and request time per zone pair upstream metrics in the same format as http zone metrics. Risk Level: low Testing: unit tests and local deployment Docs Changes: N/A Release Notes: Yes, added metrics. Platform Specific Features: N/A Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
…eader (#18550) Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Update to latest commit of xDS protos. Signed-off-by: Mark D. Roth <roth@google.com>
ssl: more fine-grained test for cert validation failure Signed-off-by: Shikugawa <rei@tetrate.io>
Reduce the coverage requirement slightly to avoid flakes. Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
…om opt build (#16043) Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Yan Avlasov <yavlasov@google.com>
Ideally limiting to envoy repo Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
tools only Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Adds support for using the matching API in the route table. This wires up using the generic match as part of a virtual host, making it possible to define a match tree that results in Route actions that reuses the same routing actions currently in use by the router. Signed-off-by: Snow Pettersen <snowp@lyft.com>
… names once (#18586) Signed-off-by: James Fish <jfish@pinterest.com>
This will help when debugging test failures. It also adds some missing field comparisons for ext_authz Response objects. Commit Message: ext_authz: add printers for ext authz and supporting types. Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: John Esmet <john.esmet@gmail.com> Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Fixes #18442 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Cleaning up a bunch of redundant code, and adding tests for goaway and data sent after half close. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
On Windows, the Read event may be removed when both the read and closed event are registered. That will lead the thread is waiting for next read event forever. So change to assertion to prevent someone registered both read and closed events. Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: wbpcode <comems@msn.com>
Just setting BAZEL_COMPILER=clang isn't enough to actually force clang. When the crosstool setup happens it uses the CC variable for this https://github.com/bazelbuild/bazel/blob/e1b842d755a01a693e79568ea11ca127b0e7bd21/tools/cpp/unix_cc_configure.bzl#L310 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: James Heppenstall <james.heppenstall@mongodb.com>
Additional Description: Part of #14696 (comment). The goal is to templatize DynamicFilterConfigProviderImpl while having DynamicFilterConfigProviderImplBase, FilterConfigProviderManagerImplBase, and FilterConfigSubscription agnostic to HTTP vs. network filters. This is a step in that direction, following the approach of #14717. Because extra validation was added since that PR, the filter factory object must be created before onConfigUpdate in addition to during Risk Level: Low Testing: Existing (refactoring) Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A #14696 Signed-off-by: Taylor Barrella <tabarr@google.com>
…8769) Signed-off-by: Mike Schore <mike.schore@gmail.com>
…8740) This patch sets response flag to UAEX when ext_authz network filter denies a connection. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
- Fix the session_timeout formatting so that it links to the RFC reference correctly. - Make some minor grammar improvements. - Quote the session_timeout field name Signed-off-by: James Peach <jpeach@apache.org>
Signed-off-by: Jose Nino <jnino@lyft.com>
…e2 (#18747) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
I noticed on #18787 we only cc shephards. I think we want to auto-assign? Risk Level: n/a (tooling) Testing: hoping for the best Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Fix #18704 Signed-off-by: Ryan Northey <ryan@synca.io>
…rs (#18701) Adds a new variant to type.v3.HashPolicy to generate a hash from an object in FilterState. This implementation mirrors what already exists for HTTP filters (see RouteAction.HashPolicy.FilterState), and is usable by network filters such as TcpProxy. Risk Level: low Testing: updated tests in tcp_proxy:config_test Docs Changes: N/A Release Notes: added an entry under tcp Platform Specific Features: N/A Signed-off-by: Dan Rosen <mergeconflict@google.com>
Fixes issue discussed here #18817 (comment) Signed-off-by: Ryan Northey <ryan@synca.io>
This should reduce the binary size, which is particularly important for Envoy Mobile. Looking at a local opt build with debug symbols, I'm seeing a drop from ~400MB to ~380MB, so maybe 5% saving. @Reflejo indicates that optimized Envoy Mobile without symbols is observing ~20% improvement. Related to #10943 Risk level: Low Testing: bazel query deps to confirm no more v2 API deps. Signed-off-by: Harvey Tuch <htuch@google.com>
Commit Message: This adds support for specifying a SinkDelegate that should be active only on the current thread. This allows for per thread overrides of the logging context, which opens up for overriding the logger for the duration of a dispatcher event as well as overriding the logger for specific function calls. Additional Description: n/a Risk Level: Low Testing: New UTs, benchmarks Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Snow Pettersen <snowp@lyft.com>
https://github.com/google/quiche/compare/4c6ad6445..1e04d1e30 Update QUICHE from 4c6ad6445 to 1e04d1e30 (#18833) $ git log 4c6ad6445..1e04d1e30 --date=short --no-merges --format="%ad %al %s" Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Genta Kamitani <oftn.mofumofu@gmail.com>
…from the platform. (#18557) Earlier attempts to integrate a requirement to manually declare TestThread made it too hard to integrate with other repos that depend on Envoy, but not on all its test infrastructure. Instead, this PR uses platform-specific mechanisms to determine whether the current thread is the 'test' thread (ie the thread in main()). This makes it unnecessary to declare TestThread anywhere. However, the TestThread empty struct is left in the codebase for now to avoid adding more conflicts with other repos. It can be removed in a month or so. A new RAII construct SkipAsserts is added as an escape for scenarios where we are integrating Envoy code in a context where the thread-checking is not relevant. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
…oded_response_handling (#18620) Commit Message: This patch removes envoy.reloadable_features.grpc_web_fix_non_proto_encoded_response_handling and relevant legacy code paths. Risk Level: Low Testing: Updated Docs Changes: N/A Release Notes: Added Platform-Specific Features: N/A Fixes #18436 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]