ext_authz: add printers for ext authz and supporting types.#18554
Merged
davinci26 merged 7 commits intoenvoyproxy:mainfrom Oct 13, 2021
Merged
ext_authz: add printers for ext authz and supporting types.#18554davinci26 merged 7 commits intoenvoyproxy:mainfrom
davinci26 merged 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
davinci26
reviewed
Oct 12, 2021
Member
davinci26
left a comment
davinci26
left a comment
There was a problem hiding this comment.
thanks, overall looks good, just a small question.
Signed-off-by: John Esmet <john.esmet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help when debugging test failures. It also adds some missing field comparisons for ext_authz Response objects.
Commit Message: ext_authz: add printers for ext authz and supporting types.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: